Re: [PATCH] dlm: use KMEM_CACHE() in dlm_memory_init()

From: Alexander Aring
Date: Wed Jun 19 2024 - 17:33:52 EST


Hi,

On Wed, Jun 19, 2024 at 4:54 PM Markus Elfring <Markus.Elfring@xxxxxx> wrote:
>
> > Using KMEM_CACHE() macro makes the code more concise and easy to read.
>
> Can the three passed name strings matter still for the identification
> of the created caches from this function implementation?
> https://elixir.bootlin.com/linux/v6.10-rc4/source/fs/dlm/memory.c#L27
> https://elixir.bootlin.com/linux/v6.10-rc4/source/mm/slab_common.c#L362

probably only for "dlm_cb" that turns into "dlm_callback". The only
place for me would be /proc/slabinfo, but I usually do `cat
/proc/slabinfo | grep dlm` to get an overview. If you are very strict
and "/proc/slabinfo" is not just "debugging" only and allowed to be
screen scraped (which I don't believe) it might can indeed break some
userspace applications.

- Alex