Re: [PATCH net-next v6 9/9] ethtool: Add ability to flash transceiver modules' firmware
From: Jakub Kicinski
Date: Wed Jun 19 2024 - 21:35:13 EST
On Wed, 19 Jun 2024 15:17:27 +0300 Danielle Ratson wrote:
> + switch (sk_priv->type) {
> + case ETHTOOL_SOCK_TYPE_MODULE_FW_FLASH:
> + ethnl_module_fw_flash_sock_destroy(sk_priv);
> + default:
> + break;
The compilers are nit picking on this:
net/ethtool/netlink.c:57:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
57 | default:
| ^
net/ethtool/netlink.c:57:2: note: insert 'break;' to avoid fall-through
57 | default:
| ^
--
pw-bot: cr