Re: [PATCH] Makefile: rust-analyzer target: better error handling and comments

[John Hubbard]

On 6/19/24 5:25 AM, Miguel Ojeda wrote:
> On Sat, Jun 1, 2024 at 2:49 AM John Hubbard <jhubbard@xxxxxxxxxx> wrote:
> >      Rust is not available
>
> Maybe we should use the `***` notation that is used elsewhere?

What exactly did you have in mind for how that should look? The
"make rustavailable" target has some leading *** and some bare
statements, so I'm not quite sure exactly how to lay it out:

$ make rustavailable
***
*** Rust bindings generator 'bindgen' is too new. This may or may not work.
***   Your version:     0.69.4
***   Expected version: 0.65.1
***
***
*** Please see Documentation/rust/quick-start.rst for details
*** on how to set up the Rust support.
***
Rust is available!



> > 2) As long as I'm there, also add some documentation about what
> > rust-analyzer provides.
>
> Perhaps this could go in a separate patch.

Sure, I'll split it out if you all prefer.

> But those are nits -- if Masahiro is OK with this approach:
>
> Acked-by: Miguel Ojeda <ojeda@xxxxxxxxxx>
>
> Happy to take it too.
>
> Cheers,
> Miguel

thanks,
--
John Hubbard
NVIDIA