Re: [PATCH] leds: cros_ec: Implement review comments from Lee

[Lee Jones]

On Thu, 20 Jun 2024, Thomas Weißschuh wrote:

> Hi Lee,
> 
> On 2024-06-20 10:31:14+0000, Lee Jones wrote:
> > Definitely not seen a commit message like that before
> 
> I assumed that this patch would be squashed into the original commit.
> 
> My question in which form you wanted the changes should have included
> "incremental series".

Incremental means on top.

A lot of maintainers don't support history re-writes, but I've reserved
that right since forever, so I can squash it if you like.

> > > Implement review comments from Lee as requested in [0] for
> > > "leds: Add ChromeOS EC driver".
> > > 
> > > Changes:
> > > * Inline DRV_NAME string constant.
> > > * Use dev_err() instead of dev_warn() to report errors.
> > > * Rename cros_ec_led_probe_led() to cros_ec_led_probe_one().
> > > * Make loop variable "int" where they belong.
> > > * Move "Unknown LED" comment to where it belongs.
> > > * Register trigger during _probe().
> > > * Use module_platform_driver() and drop all the custom boilerplate.
> > 
> > If you're fixing many things, then I would expect to receive many
> > patches.  One patch for functional change please.  If you can reasonably
> > group fixes of similar elk, then please do.  However one patch that does
> > a bunch of different things is a no-go from me, sorry.
> 
> Absolutely, if these changes are to end up as actual commits then they
> need to look different.
> I'll resend them as proper series.
> 
> > > [0] https://lore.kernel.org/lkml/20240614093445.GF3029315@xxxxxxxxxx/T/#m8750abdef6a968ace765645189170814196c9ce9
> > > 
> > > Signed-off-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
> > > ---
> > >  drivers/leds/leds-cros_ec.c | 50 +++++++++++++--------------------------------
> > >  1 file changed, 14 insertions(+), 36 deletions(-)
> 
> <snip>
> 
> Sorry for the confusion,
> Thomas

-- 
Lee Jones [李琼斯]