Re: [PATCH net-next v2 11/12] net: dsa: vsc73xx: Add bridge support

From: Vladimir Oltean
Date: Thu Jun 20 2024 - 08:43:04 EST


On Wed, Jun 19, 2024 at 10:52:17PM +0200, Pawel Dembicki wrote:
> This patch adds bridge support for vsc73xx driver.
>
> Vsc73xx require minimal operations and generic
> dsa_tag_8021q_bridge_* api is sufficient.
>
> Signed-off-by: Pawel Dembicki <paweldembicki@xxxxxxxxx>
> ---
> v2, v1:
> - Use generic functions instead unnecessary intermediary shims
> ---

Maybe you could add a small comment to the commit message that the
forwarding matrix is taken care of by vsc73xx_port_stp_state_set() ->
vsc73xx_refresh_fwd_map(), which is called immediately after
.port_bridge_join() and .port_bridge_leave().