Re: [PATCH v7 1/1] nvme-multipath: implement "queue-depth" iopolicy

[John Meneghini]

On 6/20/24 02:56, Christoph Hellwig wrote:
> > +		WARN_ON_ONCE((atomic_dec_if_positive(&ns->ctrl->nr_active)) < 0);
> Overly long line.
>
> But I don't understand why you need the WARN_ON anyway.  If the value
> must always be positive there is no point in atomic_dec_if_positive.
> If misaccounting is fine there WARN_ON is counterproductive.

Agreed. I wanted this here for testing purposes.  In all of my hours of running tests I never saw this warning go off, so I 
agree it should be removed.

/John