Re: [PATCH net-next v2] wifi: mt76: un-embedd netdev from mt76_dev

From: Simon Horman
Date: Thu Jun 20 2024 - 13:20:27 EST


On Wed, Jun 19, 2024 at 03:52:36AM -0700, Breno Leitao wrote:
> Embedding net_device into structures prohibits the usage of flexible
> arrays in the net_device structure. For more details, see the discussion
> at [1].
>
> Un-embed the net_devices from struct mt76_dev by converting them
> into pointers, and allocating them dynamically. Use the leverage
> alloc_netdev_dummy() to allocate the net_device object at
> mt76_dma_init().
>
> The free of the device occurs at mt76_dma_cleanup().
>
> Link: https://lore.kernel.org/all/20240229225910.79e224cf@xxxxxxxxxx/ [1]
> Reviewed-by: Simon Horman <horms@xxxxxxxxxx>
> Signed-off-by: Breno Leitao <leitao@xxxxxxxxxx>
> ---
>
> Changelog:
> * v2:
> - Renamed mt76_from_netdev() to mt76_priv(), and returns a
> void pointer instead of struct mt76_dev, avoiding the cast
> later, as suggested by Simon Horman.

Thanks for the update, it looks good to me.