[PATCH] Fix initializing a static union variable
From: Yabin Cui
Date: Thu Jun 20 2024 - 14:35:45 EST
saddr_wildcard is a static union variable initialized with {}.
But c11 standard doesn't guarantee initializing all fields as
zero for this case. As in https://godbolt.org/z/rWvdv6aEx,
clang only initializes the first field as zero, but the bits
corresponding to other (larger) members are undefined.
Signed-off-by: Yabin Cui <yabinc@xxxxxxxxxx>
---
net/xfrm/xfrm_state.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c
index 649bb739df0d..9bc69d703e5c 100644
--- a/net/xfrm/xfrm_state.c
+++ b/net/xfrm/xfrm_state.c
@@ -1139,7 +1139,7 @@ xfrm_state_find(const xfrm_address_t *daddr, const xfrm_address_t *saddr,
struct xfrm_policy *pol, int *err,
unsigned short family, u32 if_id)
{
- static xfrm_address_t saddr_wildcard = { };
+ static const xfrm_address_t saddr_wildcard;
struct net *net = xp_net(pol);
unsigned int h, h_wildcard;
struct xfrm_state *x, *x0, *to_put;
--
2.45.2.741.gdbec12cfda-goog