Re: [PATCH] kunit/usercopy: Add missing MODULE_DESCRIPTION()

[Rae Moar]

On Wed, Jun 19, 2024 at 4:27 PM Kees Cook <kees@xxxxxxxxxx> wrote:
>
> From: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx>
>
> Fix warning seen with:
>
> $ make allmodconfig && make W=1 C=1 lib/usercopy_kunit.ko
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/usercopy_kunit.o
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx>
> Signed-off-by: Kees Cook <kees@xxxxxxxxxx>

Hi!

This looks good to me.

Reviewed-by: Rae Moar <rmoar@xxxxxxxxxx>

Thanks!
-Rae

> ---
> At Jeff's reminder, I've split this out of:
> https://lore.kernel.org/all/20240601-md-lib-test-v1-1-a728620e37d8@xxxxxxxxxxx/
> since the file got renamed.
> ---
> Cc: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>
> Cc: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx>
> Cc: Brendan Higgins <brendan.higgins@xxxxxxxxx>
> Cc: David Gow <davidgow@xxxxxxxxxx>
> Cc: Rae Moar <rmoar@xxxxxxxxxx>
> Cc: "Gustavo A. R. Silva" <gustavoars@xxxxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: linux-kselftest@xxxxxxxxxxxxxxx
> Cc: kunit-dev@xxxxxxxxxxxxxxxx
> Cc: linux-hardening@xxxxxxxxxxxxxxx
> Cc: linux-mm@xxxxxxxxx
> ---
>  lib/usercopy_kunit.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lib/usercopy_kunit.c b/lib/usercopy_kunit.c
> index e819561a540d..77fa00a13df7 100644
> --- a/lib/usercopy_kunit.c
> +++ b/lib/usercopy_kunit.c
> @@ -331,4 +331,5 @@ static struct kunit_suite usercopy_test_suite = {
>
>  kunit_test_suites(&usercopy_test_suite);
>  MODULE_AUTHOR("Kees Cook <kees@xxxxxxxxxx>");
> +MODULE_DESCRIPTION("Kernel module for testing copy_to/from_user infrastructure");
>  MODULE_LICENSE("GPL");
> --
> 2.34.1
>