Re: [PATCH] cdx: remove unused struct 'cdx_mcdi_copy_buffer'

From: Dr. David Alan Gilbert
Date: Thu Jun 20 2024 - 20:02:57 EST


* linux@xxxxxxxxxxx (linux@xxxxxxxxxxx) wrote:
> From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
>
> 'cdx_mcdi_copy_buffer' has been unused since the original
> commit eb96b740192b ("cdx: add MCDI protocol interface for firmware
> interaction").
>
> Looking at lkml, it was used in the V1 posting but was removed
> somewhere before V6.
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx>

Ping.

Dave

> ---
> drivers/cdx/controller/mcdi.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/cdx/controller/mcdi.c b/drivers/cdx/controller/mcdi.c
> index 1eedc5eeb315..e760f8d347cc 100644
> --- a/drivers/cdx/controller/mcdi.c
> +++ b/drivers/cdx/controller/mcdi.c
> @@ -27,10 +27,6 @@
> #include "bitfield.h"
> #include "mcdi.h"
>
> -struct cdx_mcdi_copy_buffer {
> - struct cdx_dword buffer[DIV_ROUND_UP(MCDI_CTL_SDU_LEN_MAX, 4)];
> -};
> -
> static void cdx_mcdi_cancel_cmd(struct cdx_mcdi *cdx, struct cdx_mcdi_cmd *cmd);
> static void cdx_mcdi_wait_for_cleanup(struct cdx_mcdi *cdx);
> static int cdx_mcdi_rpc_async_internal(struct cdx_mcdi *cdx,
> --
> 2.45.1
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/