Re: [PATCH v12 2/9] cpufreq: simplify boolean parsing with kstrtobool in store function

[Gautham R . Shenoy]

Perry Yuan <perry.yuan@xxxxxxx> writes:

> Update the cpufreq store function to use kstrtobool for parsing boolean
> values. This simplifies the code and improves readability by using a
> standard kernel function for boolean string conversion.
>
> Signed-off-by: Perry Yuan <perry.yuan@xxxxxxx>
> Reviewed-by: Mario Limonciello <mario.limonciello@xxxxxxx>
Reviewed-by: Gautham R. Shenoy <gautham.shenoy@xxxxxxx>

> ---
>  drivers/cpufreq/cpufreq.c | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index a45aac17c20f..1fdabb660231 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -614,10 +614,9 @@ static ssize_t show_boost(struct kobject *kobj,
>  static ssize_t store_boost(struct kobject *kobj, struct kobj_attribute *attr,
>  			   const char *buf, size_t count)
>  {
> -	int ret, enable;
> +	bool enable;
>  
> -	ret = sscanf(buf, "%d", &enable);
> -	if (ret != 1 || enable < 0 || enable > 1)
> +	if (kstrtobool(buf, &enable))
>  		return -EINVAL;
>  
>  	if (cpufreq_boost_trigger_state(enable)) {
> @@ -641,10 +640,10 @@ static ssize_t show_local_boost(struct cpufreq_policy *policy, char *buf)
>  static ssize_t store_local_boost(struct cpufreq_policy *policy,
>  				 const char *buf, size_t count)
>  {
> -	int ret, enable;
> +	int ret;
> +	bool enable;
>  
> -	ret = kstrtoint(buf, 10, &enable);
> -	if (ret || enable < 0 || enable > 1)
> +	if (kstrtobool(buf, &enable))
>  		return -EINVAL;
>  
>  	if (!cpufreq_driver->boost_enabled)
> -- 
> 2.34.1