回复: [PATCH v4 11/13] staging: media: starfive: Add ISP params video device

[Changhuang Liang]

Hi, Hans

Thanks for your comments.

[...]
> > +static int stf_isp_params_queue_setup(struct vb2_queue *q,
> > +				      unsigned int *num_buffers,
> > +				      unsigned int *num_planes,
> > +				      unsigned int sizes[],
> > +				      struct device *alloc_devs[]) {
> 
> Add:
> 
>         if (*nplanes)
>                 return sizes[0] < sizeof(struct jh7110_isp_params_buffer ?
> -EINVAL : 0;
> 

Will add this.

> > +	*num_planes = 1;
> > +	sizes[0] = sizeof(struct jh7110_isp_params_buffer);
> > +
> > +	return 0;
> > +}
> > +
[...]
> > +static const struct v4l2_file_operations stf_isp_params_fops = {
> > +	.owner          = THIS_MODULE,
> > +	.unlocked_ioctl = video_ioctl2,
> > +	.open           = v4l2_fh_open,
> > +	.release        = vb2_fop_release,
> > +	.poll           = vb2_fop_poll,
> > +	.mmap           = vb2_fop_mmap,
> > +	.read           = vb2_fop_read,
> 
> This isn't needed since no read support is indicated in q->io_modes.
> 

Wil drop read support.

> Note: I see that this is also set in stf_vid_fops, but it can be dropped there as
> well. Please make a separate patch for that change.
> 

Will add a new patch drop read support in stf_vid_fops.

Regards,
Changhuang