Re: [PATCH v2 net-next] net: dsa: Allow only up to two HSR HW offloaded ports for KSZ9477

[Vladimir Oltean]

On Fri, Jun 21, 2024 at 10:31:44AM +0200, Lukasz Majewski wrote:
> > That being said, I think the responsibility falls on your side here,
> > given that you introduced a new HSR port type and offload drivers
> > still implicitly think it's a ring port, because there's no API to
> > tell them otherwise.
> 
> IMHO, the above problem is not related to the patch send here. It shall
> be addressed with new patch series.

Why is it not related? Testing for HSR port type is the explicit and
more predictable variant of your current patch that waits for the
3rd NETDEV_CHANGEUPPER notifier and implicitly associates it with an
interlink port. If you're going to add the ability to test for HSR port
type in offloading drivers anyway, I don't understand why you wouldn't
want to opt for a uniform approach in ksz9477.