Re: [PATCH net-next v3 1/7] net: ethtool: pse-pd: Expand C33 PSE status with class, power and extended state

[Kory Maincent]

On Mon, 17 Jun 2024 21:55:25 +0200
Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> wrote:

> On Mon, Jun 17, 2024 at 03:47:12PM +0200, Kory Maincent wrote:
>  [...]  
> > 
> > Mmh not really indeed, maybe we can put it in error_condition substate?  
> 
> I'm not sure how this error can help user, if even we do not understand
> what is says. May be map everything what is not clear right not to
> unsupported error value. This give us some time to communicate with
> vendor and prevent us from making pointless UAPi?

Is it ok for you if I use this substate for unsupported value:
ETHTOOL_C33_PSE_EXT_SUBSTATE_ERROR_CONDITION_UNKNOWN_PORT_STATUS
or do you prefer another one.

> > Should I put it under MPS substate then?  
> 
> If my understand is correct, then yes. Can you test it? Do you have PD
> with adjustable load?

Yes I will test it.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com