Re: [PATCH v9 0/8] remoteproc: qcom: q6v5-wcss: Add support for secure pil

From: Dmitry Baryshkov
Date: Fri Jun 21 2024 - 17:22:42 EST


On Fri, Jun 21, 2024 at 05:16:51PM GMT, Gokul Sriram Palanisamy wrote:
> IPQ8074 needs support for secure pil as well.

Could you please settle on 'pil' or 'PIL'. Just use one of them.
Explain, what is secure PIL.

> Also, currently only unified firmware is supported.

What is unified firmware? What is split firmware? Why do I have so many
questions after reading the cover letter for what claims to be v9?

> IPQ8074 supports split firmware for q6 and m3, so
> adding support for that.

Ok. After reading through the first few patches. Is WCSS support on
IPQ8074 broken?

>
> changes since v8:
> - Rebased on top of Linux 6.10-rc4

Previous changelog has wanished?

>
> Gokul Sriram Palanisamy (8):
> remoteproc: qcom: Add PRNG proxy clock
> remoteproc: qcom: Add secure PIL support
> remoteproc: qcom: Add support for split q6 + m3 wlan firmware
> remoteproc: qcom: Add ssr subdevice identifier
> remoteproc: qcom: Update regmap offsets for halt register
> dt-bindings: clock: qcom: Add reset for WCSSAON
> clk: qcom: Add WCSSAON reset
> arm64: dts: qcom: Enable Q6v5 WCSS for ipq8074 SoC
>
> arch/arm64/boot/dts/qcom/ipq8074.dtsi | 80 +++++++++
> drivers/clk/qcom/gcc-ipq8074.c | 1 +
> drivers/remoteproc/qcom_q6v5_wcss.c | 162 +++++++++++++++----
> include/dt-bindings/clock/qcom,gcc-ipq8074.h | 1 +
> 4 files changed, 212 insertions(+), 32 deletions(-)
>
> --
> 2.34.1
>

--
With best wishes
Dmitry