Re: [PATCH v3 1/2] mfd: syscon: add of_syscon_register_regmap() API

From: William McVicker
Date: Fri Jun 21 2024 - 19:56:28 EST


On 06/21/2024, Peter Griffin wrote:
> The of_syscon_register_regmap() API allows an externally created regmap
> to be registered with syscon. This regmap can then be returned to client
> drivers using the syscon_regmap_lookup_by_phandle() APIs.
>
> The API is used by platforms where mmio access to the syscon registers is
> not possible, and a underlying soc driver like exynos-pmu provides a SoC
> specific regmap that can issue a SMC or hypervisor call to write the
> register.
>
> This approach keeps the SoC complexities out of syscon, but allows common
> drivers such as syscon-poweroff, syscon-reboot and friends that are used
> by many SoCs already to be re-used.
>
> Signed-off-by: Peter Griffin <peter.griffin@xxxxxxxxxx>
> Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>
> Reviewed-by: Sam Protsenko <semen.protsenko@xxxxxxxxxx>

Tested-by: Will McVicker <willmcvicker@xxxxxxxxxx>

[...]

Thanks Peter! I've tested the patch series on my Pixel 6 Pro and all is working
well. I verified all the modularized drivers load and probe successfully:

root@google-gs:~# lsmod
Module Size Used by
at24 24576 0
dwc3_exynos 12288 0
i2c_exynos5 28672 0
phy_exynos_ufs 20480 1
ufs_exynos 32768 0
phy_exynos5_usbdrd 36864 2
s3c2410_wdt 24576 0
arm_dsu_pmu 24576 0

Thanks,
Will