Re: [PATCH net-next v8 09/13] net: phy: mediatek: Add token ring access helper functions in mtk-phy-lib

[Andrew Lunn]

On Fri, Jun 21, 2024 at 08:20:41PM +0800, Sky Huang wrote:
> From: "SkyLake.Huang" <skylake.huang@xxxxxxxxxxxx>
> 
> This patch adda TR(token ring) manipulations and add correct

s/adda/adds

plus "adds the correct macro names for"

> macro name for those magic numbers. TR is a way to access
> proprietary register on page 52b5. Use these helper functions

registers

> +/* ch_addr = 0x2, node_addr = 0xd, data_addr = 0x8 */
> +/* clear this bit if wanna select from AFE */
> +/* Regsigdet_sel_1000 */
> +#define EEE1000_SELECT_SIGNEL_DETECTION_FROM_DFE	BIT(4)

Should that be SIGNAL?

	Andrew