Re: [PATCH] dmaengine: axi-dmac: Add check for dma_set_max_seg_size

From: Markus Elfring
Date: Sun Jun 23 2024 - 09:24:14 EST

Next message: Ma Ke: "[PATCH] drm/amd/display: Add otg_master NULL check within init_pipe_slice_table_from_context"
Previous message: Ma Ke: "[PATCH] selftests/bpf: don't close(-1) in serial_test_fexit_stress()"
In reply to: Ma Ke: "[PATCH] dmaengine: axi-dmac: Add check for dma_set_max_seg_size"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

> To avoid possible failure of the dma_set_max_seg_size(),

Really?

It is desirable to detect a failed function call, isn't it?

> we should better check the return value of the dma_set_max_seg_size().

1. Please choose an imperative wording for an improved change description.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc4#n94

2. Would you like to add any tags (like “Fixes” and “Cc”) accordingly?

3. How do you think about to append the text “() in axi_dmac_probe()”
to the summary phrase?

Regards,
Markus

Next message: Ma Ke: "[PATCH] drm/amd/display: Add otg_master NULL check within init_pipe_slice_table_from_context"
Previous message: Ma Ke: "[PATCH] selftests/bpf: don't close(-1) in serial_test_fexit_stress()"
In reply to: Ma Ke: "[PATCH] dmaengine: axi-dmac: Add check for dma_set_max_seg_size"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]