Re: [PATCH 3/8] iio: add child nodes support in iio backend framework

From: Jonathan Cameron
Date: Sun Jun 23 2024 - 10:01:48 EST


On Tue, 18 Jun 2024 18:08:29 +0200
Olivier Moysan <olivier.moysan@xxxxxxxxxxx> wrote:

> Add an API to support IIO generic channels binding:
> http://devicetree.org/schemas/iio/adc/adc.yaml#
> This new API is needed, as generic channel DT node
> isn't populated as a device.
> Add devm_iio_backend_subnode_get() to allow an IIO device
> backend consumer to configure backend phandles in its
> child nodes.

Really trivial stuff:

Don't wrap so far below 75 chars that is typical limit
for commit messages.

>
> Signed-off-by: Olivier Moysan <olivier.moysan@xxxxxxxxxxx>

> +
> +/**
> + * devm_iio_backend_get - Device managed backend device get
> + * @dev: Consumer device for the backend
> + * @name: Backend name
> + *
> + * Get's the backend associated with @dev.
> + *
> + * RETURNS:
> + * A backend pointer, negative error pointer otherwise.
> + */
> +struct iio_backend *devm_iio_backend_get(struct device *dev, const char *name)
> +{
> + return __devm_iio_backend_node_get(dev, name, dev_fwnode(dev));
> +}
> EXPORT_SYMBOL_NS_GPL(devm_iio_backend_get, IIO_BACKEND);
>
> +/**
> + * devm_iio_backend_subnode_get - Device managed backend device get

Same short description as the one above. Fairly sure this wants to be different!

> + * @dev: Consumer device for the backend
> + * @name: Backend name
> + * @node: Firmware node of the backend consumer
> + *
> + * Get's the backend associated with @dev.
> + *
> + * RETURNS:
> + * A backend pointer, negative error pointer otherwise.
> + */
> +struct iio_backend *devm_iio_backend_subnode_get(struct device *dev, const char *name,
> + struct fwnode_handle *node)
> +{
> + return __devm_iio_backend_node_get(dev, name, node);
> +}
> +EXPORT_SYMBOL_NS_GPL(devm_iio_backend_subnode_get, IIO_BACKEND);