Re: [PATCH 1/3] power: supply: ab8500: Fix error handling when calling iio_read_channel_processed()

From: Jonathan Cameron
Date: Sun Jun 23 2024 - 13:17:14 EST


On Sat, 22 Jun 2024 09:04:24 +0200
Christophe JAILLET <christophe.jaillet@xxxxxxxxxx> wrote:

> The ab8500_charger_get_[ac|vbus]_[current|voltage]() functions should
> return an error code on error.
>
> Up to now, an un-initialized value is returned.
> This makes the error handling of the callers un-reliable.
>
> Return the error code instead, to fix the issue.
>
> Fixes: 97ab78bac5d0 ("power: supply: ab8500_charger: Convert to IIO ADC")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
Looks right to me.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>