Re: [PATCH] sched_ext: Make scx_bpf_cpuperf_set() @cpu arg signed

From: Tejun Heo
Date: Sun Jun 23 2024 - 13:54:14 EST


On Sun, Jun 23, 2024 at 03:10:36AM -0500, David Vernet wrote:
> The scx_bpf_cpuperf_set() kfunc allows a BPF program to set the relative
> performance target of a specified CPU. Commit d86adb4fc065 ("sched_ext: Add
> cpuperf support") defined the @cpu argument to be unsigned. Let's update it
> to be signed to match the norm for the rest of ext.c and the kernel.
>
> Note that the kfunc declaration of scx_bpf_cpuperf_set() in the
> common.bpf.h header in tools/sched_ext already listed the cpu as signed, so
> this also fixes the build for tools/sched_ext and the sched_ext selftests
> due to kfunc declarations now being emitted in vmlinux.h based on BTF (thus
> causing the compiler to error due to observing conflicting types).
>
> Fixes: d86adb4fc065 ("sched_ext: Add cpuperf support")
> Signed-off-by: David Vernet <void@xxxxxxxxxxxxx>

Applied to sched_ext/for-6.11.

Thanks.

--
tejun