Re: [PATCH v2 0/7] Enable CPR for IPQ9574

From: Varadarajan Narayanan
Date: Mon Jun 24 2024 - 02:50:57 EST


On Mon, Jun 24, 2024 at 08:39:55AM +0300, Dmitry Baryshkov wrote:
> On Mon, Jun 24, 2024 at 10:32:47AM GMT, Varadarajan Narayanan wrote:
> > This series tries to enable CPR on IPQ9574, that implements
> > CPRv4. Since [1] is older, faced few minor issues. Those are
> > addressed in [2].
> >
> > dt_binding_check and dtbs_check passed.
> >
> > Depends:
> > [1] https://lore.kernel.org/lkml/20230217-topic-cpr3h-v14-0-9fd23241493d@xxxxxxxxxx/T/
> > [2] https://github.com/quic-varada/cpr/commits/konrad/
>
> Please include [2] into your patchset.

Did not include them because Konrad has agreed to post them this week.
And, I don't have an MSM8998 target to test those changes.

Thanks
Varada

> >
> > v2: Fix Signed-off-by order in 2 patches
> > Update constraints in qcom,cpr3.yaml
> > Add rbcpr_clk_src registration
> > Add Reviewed-by to one of the patches
> > Not adding Acked-by as the file has changed
> >
> > Varadarajan Narayanan (7):
> > dt-bindings: power: rpmpd: Add IPQ9574 power domains
> > dt-bindings: soc: qcom: cpr3: Add bindings for IPQ9574
> > pmdomain: qcom: rpmpd: Add IPQ9574 power domains
> > dt-bindings: clock: Add CPR clock defines for IPQ9574
> > clk: qcom: gcc-ipq9574: Add CPR clock definition
> > soc: qcom: cpr3: Add IPQ9574 definitions
> > dts: arm64: qcom: ipq9574: Enable CPR
> >
> > .../devicetree/bindings/power/qcom,rpmpd.yaml | 1 +
> > .../bindings/soc/qcom/qcom,cpr3.yaml | 35 +++
> > arch/arm64/boot/dts/qcom/ipq9574.dtsi | 269 ++++++++++++++++--
> > drivers/clk/qcom/gcc-ipq9574.c | 39 +++
> > drivers/pmdomain/qcom/cpr3.c | 137 +++++++++
> > drivers/pmdomain/qcom/rpmpd.c | 19 ++
> > include/dt-bindings/clock/qcom,ipq9574-gcc.h | 2 +
> > include/dt-bindings/power/qcom-rpmpd.h | 3 +
> > 8 files changed, 488 insertions(+), 17 deletions(-)
> >
> > --
> > 2.34.1
> >
>
> --
> With best wishes
> Dmitry