Re: [PATCH v4 12/15] drm/mediatek: add MT8365 SoC support

[Alexandre Mergnat]

On 21/06/2024 17:24, Chun-Kuang Hu wrote:
> Hi, Alexandre:
>
> <amergnat@xxxxxxxxxxxx>  於 2024年5月23日 週四 下午8:49寫道：
> > From: Fabien Parent<fparent@xxxxxxxxxxxx>
> >
> > Add DRM support for MT8365 SoC.
> >
> > Signed-off-by: Fabien Parent<fparent@xxxxxxxxxxxx>
> > Reviewed-by: AngeloGioacchino Del Regno<angelogioacchino.delregno@xxxxxxxxxxxxx>
> > Signed-off-by: Alexandre Mergnat<amergnat@xxxxxxxxxxxx>
> > ---
> >   drivers/gpu/drm/mediatek/mtk_drm_drv.c | 8 ++++++++
> >   1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> > index ce8f3cc6e853..e1c3281651ae 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> > @@ -318,6 +318,10 @@ static const struct mtk_mmsys_driver_data mt8195_vdosys1_driver_data = {
> >          .mmsys_dev_num = 2,
> >   };
> >
> > +static const struct mtk_mmsys_driver_data mt8365_mmsys_driver_data = {
> > +       .mmsys_dev_num = 1,
> You do not describe the pipeline information here. I think display
> function would not work.

Hi Chun-Kuang,

I don't describe the pipeline information here because I do it
in the DTS thanks to the OF graphs Angelo's serie [1].
I've tested DSI and DPI display, they work correctly ;)

[1] https://lore.kernel.org/all/20240618101726.110416-1-angelogioacchino.delregno@xxxxxxxxxxxxx/

--
Regards,
Alexandre