Re: [PATCH v2 6/8] Add debug log info to msm_csid_subdev_init function

From: Krzysztof Kozlowski
Date: Mon Jun 24 2024 - 06:20:16 EST


On 24/06/2024 12:08, Bryan O'Donoghue wrote:
> On 24/06/2024 00:22, George Chan via B4 Relay wrote:
>> + dev_err(dev, "missing clk %s", res->clock[i]);
>
> Please don't abbreviate - the other error message says "clock" here we
> say "clk"
>

Is it a probe path? If yes, then this should be dev_err_probe. If not,
then are you sure that non-probe paths should acquire resources? How
does it handle deferred probe in such case?

Best regards,
Krzysztof