Re: [PATCH 2/2] mm/zswap: use only one pool in zswap

From: Yosry Ahmed
Date: Mon Jun 24 2024 - 07:39:58 EST


On Mon, Jun 17, 2024 at 1:20 PM Yu Zhao <yuzhao@xxxxxxxxxx> wrote:
>
> On Mon, Jun 17, 2024 at 2:16 PM Yu Zhao <yuzhao@xxxxxxxxxx> wrote:
> >
> > On Mon, Jun 17, 2024 at 6:58 AM Chengming Zhou <chengming.zhou@xxxxxxxxx> wrote:
> > >
> > > Zswap uses 32 pools to workaround the locking scalability problem in
> > > zsmalloc,
> >
> > Note that zpool can have other backends (zbud, z3fold), and the
> > original patch was developed (even before zswap could use zsmalloc) to
> > make sure it works for all the backend.
> >
> > This patch only makes sense now only because zsmalloc became a lot
> > more popular than other backends (even though some distros still
> > default to zbud).
>
> And this might also have answered Yosry's question about the
> "historical context" here [1].
>
> [1] https://lore.kernel.org/CAJD7tkbO+ZLdhs-9BpthztZX32i8C4=QEnoiXGS7bM399nqwzg@xxxxxxxxxxxxxx/

It does, thanks.