Re: [PATCH v2 1/3] dt-bindings: clock: Add x1e80100 LPASS AUDIOCC reset controller

[Krzysztof Kozlowski]

On 24/06/2024 15:32, Srinivas Kandagatla wrote:
> X1E80100 LPASS (Low Power Audio Subsystem) Audio clock controller
> provides reset support when it is under the control of Q6DSP.
> 
> Add x1e80100 compatible to the existing sc8280xp as these reset
> controllers have same reg layout and compatible.
> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
> ---
>  .../devicetree/bindings/clock/qcom,sc8280xp-lpasscc.yaml      | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/qcom,sc8280xp-lpasscc.yaml b/Documentation/devicetree/bindings/clock/qcom,sc8280xp-lpasscc.yaml
> index 3326dcd6766c..c33bf4c5af7d 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,sc8280xp-lpasscc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,sc8280xp-lpasscc.yaml
> @@ -18,10 +18,13 @@ description: |
>  
>  properties:
>    compatible:
> -    enum:
> -      - qcom,sc8280xp-lpassaudiocc
> -      - qcom,sc8280xp-lpasscc
> -
> +    oneOf:
> +      - enum:
> +          - qcom,sc8280xp-lpassaudiocc
> +          - qcom,sc8280xp-lpasscc
> +      - items:
> +          - const: qcom,x1e80100-lpassaudiocc
> +          - const: qcom,sc8280xp-lpassaudiocc

Please keep here blank line. With this:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

>    reg:
>      maxItems: 1
>  
> 

Best regards,
Krzysztof