Re: [PATCH v5 1/2] dt-bindings: power: supply: add support for MAX17201/MAX17205 fuel gauge

From: Conor Dooley
Date: Mon Jun 24 2024 - 13:07:39 EST


On Fri, Jun 21, 2024 at 02:57:43PM +0200, Dimitri Fedrau wrote:
> Adding documentation for MAXIMs MAX17201/MAX17205 fuel gauge.
>
> Signed-off-by: Dimitri Fedrau <dima.fedrau@xxxxxxxxx>
> ---
> .../bindings/power/supply/maxim,max1720x.yaml | 58 +++++++++++++++++++
> 1 file changed, 58 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/power/supply/maxim,max1720x.yaml
>
> diff --git a/Documentation/devicetree/bindings/power/supply/maxim,max1720x.yaml b/Documentation/devicetree/bindings/power/supply/maxim,max1720x.yaml
> new file mode 100644
> index 000000000000..dc3e0e7cb2ce
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/maxim,max1720x.yaml
> @@ -0,0 +1,58 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/power/supply/maxim,max1720x.yaml#

s/1720x/17201/ both here, the title and in the filename please.
With that changed,
Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

Thanks,
Conor.

> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Maxim MAX1720x fuel gauge
> +
> +maintainers:
> + - Dimitri Fedrau <dima.fedrau@xxxxxxxxx>
> +
> +allOf:
> + - $ref: power-supply.yaml#
> +
> +properties:
> + compatible:
> + oneOf:
> + - const: maxim,max17201
> + - items:
> + - enum:
> + - maxim,max17205
> + - const: maxim,max17201
> +
> + reg:
> + items:
> + - description: ModelGauge m5 registers
> + - description: Nonvolatile registers
> +
> + reg-names:
> + items:
> + - const: m5
> + - const: nvmem
> +
> + interrupts:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - reg-names
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + fuel-gauge@36 {
> + compatible = "maxim,max17201";
> + reg = <0x36>, <0xb>;
> + reg-names = "m5", "nvmem";
> + interrupt-parent = <&gpio0>;
> + interrupts = <31 IRQ_TYPE_LEVEL_LOW>;
> + };
> + };
> --
> 2.39.2
>

Attachment: signature.asc
Description: PGP signature