Re: [PATCH net-next v7 5/9] ethtool: Veto some operations during firmware flashing process

From: Andrew Lunn
Date: Mon Jun 24 2024 - 15:31:51 EST


On Mon, Jun 24, 2024 at 08:51:55PM +0300, Danielle Ratson wrote:
> Some operations cannot be performed during the firmware flashing
> process.
>
> For example:
>
> - Port must be down during the whole flashing process to avoid packet loss
> while committing reset for example.
>
> - Writing to EEPROM interrupts the flashing process, so operations like
> ethtool dump, module reset, get and set power mode should be vetoed.
>
> - Split port firmware flashing should be vetoed.
>
> In order to veto those scenarios, add a flag in 'struct net_device' that
> indicates when a firmware flash is taking place on the module and use it
> to prevent interruptions during the process.
>
> Signed-off-by: Danielle Ratson <danieller@xxxxxxxxxx>
> Reviewed-by: Petr Machata <petrm@xxxxxxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Andrew