[PATCH] ipmi: Combine identical if checks
From: Thorsten Blum
Date: Mon Jun 24 2024 - 16:48:44 EST
Check for run_to_completion only once.
Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxxx>
---
drivers/char/ipmi/ipmi_msghandler.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
index e12b531f5c2f..b7d8eb0a3432 100644
--- a/drivers/char/ipmi/ipmi_msghandler.c
+++ b/drivers/char/ipmi/ipmi_msghandler.c
@@ -4870,12 +4870,12 @@ void ipmi_smi_msg_received(struct ipmi_smi *intf,
if (!run_to_completion)
spin_lock_irqsave(&intf->waiting_rcv_msgs_lock, flags);
list_add_tail(&msg->link, &intf->waiting_rcv_msgs);
- if (!run_to_completion)
+ if (!run_to_completion) {
spin_unlock_irqrestore(&intf->waiting_rcv_msgs_lock,
flags);
-
- if (!run_to_completion)
spin_lock_irqsave(&intf->xmit_msgs_lock, flags);
+ }
+
/*
* We can get an asynchronous event or receive message in addition
* to commands we send.
--
2.45.2