Re: [PATCH v39 02/42] SM: Infrastructure management of the sock security

From: Paul Moore
Date: Mon Jun 24 2024 - 18:08:02 EST


On Fri, Jun 21, 2024 at 4:31 PM Paul Moore <paul@xxxxxxxxxxxxxx> wrote:
> On Fri, Dec 15, 2023 at 5:18 PM Casey Schaufler <casey@xxxxxxxxxxxxxxxx> wrote:
> >
> > Move management of the sock->sk_security blob out
> > of the individual security modules and into the security
> > infrastructure. Instead of allocating the blobs from within
> > the modules the modules tell the infrastructure how much
> > space is required, and the space is allocated there.
> >
> > Acked-by: Paul Moore <paul@xxxxxxxxxxxxxx>
> > Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>
> > Reviewed-by: John Johansen <john.johansen@xxxxxxxxxxxxx>
> > Acked-by: Stephen Smalley <stephen.smalley.work@xxxxxxxxx>
> > Signed-off-by: Casey Schaufler <casey@xxxxxxxxxxxxxxxx>
> > ---
> > include/linux/lsm_hooks.h | 1 +
> > security/apparmor/include/net.h | 3 +-
> > security/apparmor/lsm.c | 20 +-------
> > security/apparmor/net.c | 2 +-
> > security/security.c | 36 ++++++++++++++-
> > security/selinux/hooks.c | 76 ++++++++++++++-----------------
> > security/selinux/include/objsec.h | 5 ++
> > security/selinux/netlabel.c | 23 +++++-----
> > security/smack/smack.h | 5 ++
> > security/smack/smack_lsm.c | 70 ++++++++++++++--------------
> > security/smack/smack_netfilter.c | 4 +-
> > 11 files changed, 131 insertions(+), 114 deletions(-)
>
> I had to do some minor merge fixups, but I just merged this into the
> lsm/dev-staging branch to do some testing, assuming all goes well I'll
> move this over to the lsm/dev branch; I'll send another note if/when
> that happens.

Everything looked good so I've merged this into lsm/dev. Thanks all.

--
paul-moore.com