Re: [PATCH v2] tty: serial: ma35d1: Add a NULL check for of_node

[Jacky Huang]

Dear Greg,


On 2024/6/24 下午 09:37, Greg KH wrote:
> On Fri, Jun 14, 2024 at 05:45:54AM +0000, Jacky Huang wrote:
> > From: Jacky Huang <ychuang3@xxxxxxxxxxx>
> >
> > The pdev->dev.of_node can be NULL if the "serial" node is absent.
> > Add a NULL check to return an error in such cases.
> >
> > Fixes: 930cbf92db01 ("tty: serial: Add Nuvoton ma35d1 serial driver support")
> > Signed-off-by: Jacky Huang <ychuang3@xxxxxxxxxxx>
> You forgot a "Reported-by:" line as Dan did report this to you.
>
> > ---
> >   drivers/tty/serial/ma35d1_serial.c | 13 +++++++------
> >   1 file changed, 7 insertions(+), 6 deletions(-)
> Also, no info as to what changed from v1 :(
>
> thanks,
>
> greg k-h

I got it. I will add the "Reported-by:" line and version info to the v3 
patch.


Best Regards,
Jacky Huang