Re: [PATCH v3 2/4] perf: disasm: use build_id_path if fallback failed

From: duchangbin
Date: Mon Jun 24 2024 - 21:48:07 EST


On Mon, Jun 24, 2024 at 05:08:18PM -0700, Namhyung Kim wrote:
> Hello,
>
> On Tue, Jun 18, 2024 at 09:55:28AM +0800, Changbin Du wrote:
> > If we can not fallback for special dso (vmlinx and vdso), use the
> > build_id_path found previously.
> >
> > To make change easy, this change first refactors the code by extracting
> > two functions read_buildid_linkname() and fallback_filename().
>
> Can you please split the refactoring from the actual change? It'd be
> easier to review and to maintain the code.
>
Sure, I'll do it taday.

> Thanks,
> Namhyung
>

--
Cheers,
Changbin Du