Re: [PATCH] scsi:Replace printk and WARN_ON with WARN macro

From: James Bottomley
Date: Mon Jun 24 2024 - 22:55:01 EST


On Mon, 2024-06-24 at 13:32 -0400, Prabhakar Pujeri wrote:
> This patch modifies the error handling in the SCSI library and Initio
> SCSI driver by replacing the combination of printk and WARN_ON macros
> with the WARN macro for better consistency and readability.

Although this patch does exactly what it says, we have a problem
applying it in that the initio driver is now so old that almost no-one
has hardware for it. As a result we're very reluctant to touch this
driver for anything other than critical fixes in case we accidentally
break it and no-one notices for months.

Regards,

James Bottomley