Re: [tip:irq/core 39/46] drivers/irqchip/irq-loongarch-avec.c:82:17: error: implicit declaration of function 'loongson_send_ipi_single'

From: Tianyang Zhang
Date: Tue Jun 25 2024 - 01:00:29 EST


Hi, Thomas

在 2024/6/24 下午9:45, Thomas Gleixner 写道:
On Mon, Jun 24 2024 at 05:06, kernel test robot wrote:
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git irq/core
head: c9d269469d2b9a06559cdc84d12dd3fb4d552581
commit: 760d7e719499d64beea62bfcf53938fb233bb6e7 [39/46] Loongarch: Support loongarch avec
config: loongarch-allnoconfig (https://download.01.org/0day-ci/archive/20240624/202406240451.ygBFNyJ3-lkp@xxxxxxxxx/config)
compiler: loongarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240624/202406240451.ygBFNyJ3-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406240451.ygBFNyJ3-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

drivers/irqchip/irq-loongarch-avec.c: In function 'loongarch_avec_sync':
drivers/irqchip/irq-loongarch-avec.c:82:17: error: implicit declaration of function 'loongson_send_ipi_single' [-Werror=implicit-function-declaration]
82 | loongson_send_ipi_single(adata->prev_cpu, SMP_CLEAR_VECT);
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/irqchip/irq-loongarch-avec.c:82:59: error: 'SMP_CLEAR_VECT' undeclared (first use in this function)
82 | loongson_send_ipi_single(adata->prev_cpu, SMP_CLEAR_VECT);
| ^~~~~~~~~~~~~~
drivers/irqchip/irq-loongarch-avec.c:82:59: note: each undeclared identifier is reported only once for each function it appears in
drivers/irqchip/irq-loongarch-avec.c: In function 'complete_irq_moving':
drivers/irqchip/irq-loongarch-avec.c:173:55: error: 'SMP_CLEAR_VECT' undeclared (first use in this function)
173 | loongson_send_ipi_single(cpu, SMP_CLEAR_VECT);
| ^~~~~~~~~~~~~~
So this code was never built with CONFIG_SMP=n.

Can the loongson folks please send me a delta patch ASAP, otherwise I'm
going to revert it.

Thanks,

tglx

We have also noticed this issue and found that the patch has other issues that may cause it to fail to start on a certain model of machine.
If possible, please reverse this patch and we will resend a V2 version patch as soon as possible based on this patch

Thanks you

            Tianyang