Re: [PATCH v7 2/3] dt-bindings: iio: proximity: Add TYHX HX9023S
From: Krzysztof Kozlowski
Date: Tue Jun 25 2024 - 01:49:15 EST
On 25/06/2024 04:15, Yasin Lee wrote:
> A capacitive proximity sensor
>
> Acked-by: Conor Dooley <conor@xxxxxxxxxx>
> Acked-by: Jonathan Cameron <jic23@xxxxxxxxxx>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
What? How did this happen? Where - provide lore links to prove it?
NAK
> Reported-by: "Rob Herring (Arm)" <robh@xxxxxxxxxx>
No, drop.
> Signed-off-by: Yasin Lee <yasin.lee.x@xxxxxxxxx>
> +
> +patternProperties:
> + "^channel@[0-4]$":
> + $ref: /schemas/iio/adc/adc.yaml
> + type: object
> +
> + properties:
> + reg:
> + minimum: 0
> + maximum: 4
> + description: The channel number.
> +
> + single-channel: true
> +
> + diff-channels: true
> +
> + oneOf:
> + - required:
> + - single-channel
> + - required:
> + - diff-channels
> +
> + required:
> + - reg
... and now you should see that you duplicated adc.yaml. This should be
just:
+patternProperties:
+ "^channel@[0-4]$":
+ $ref: /schemas/iio/adc/adc.yaml
+ type: object
+ unevaluatedProperties: false
+
+ properties:
+ reg:
+ minimum: 0
+ maximum: 4
+ description: The channel number.
Best regards,
Krzysztof