Re: [PATCH v9 4/8] remoteproc: qcom: Add ssr subdevice identifier
From: Dmitry Baryshkov
Date: Tue Jun 25 2024 - 03:15:19 EST
On Tue, Jun 25, 2024 at 09:04:17AM GMT, Krzysztof Kozlowski wrote:
> On 25/06/2024 08:28, Gokul Sriram P wrote:
> >
> > On 6/21/2024 8:40 PM, Krzysztof Kozlowski wrote:
> >> On 21/06/2024 13:46, Gokul Sriram Palanisamy wrote:
> >>> Add name for ssr subdevice on IPQ8074 SoC.
> >> Why?
> > Oops! Missed the change. Will add and update.
> >>> Signed-off-by: Nikhil Prakash V<quic_nprakash@xxxxxxxxxxx>
> >>> Signed-off-by: Sricharan R<quic_srichara@xxxxxxxxxxx>
> >>> Signed-off-by: Gokul Sriram Palanisamy<quic_gokulsri@xxxxxxxxxxx>
> >> Three people developed that single line?
> >>
> >> Something is really odd with your DCO chain.
> > The change was originally authored by Nikhil and reviewed by
> > Sricharan. I'm just submitting the change to upstream so retained their
> > names.
> >>
>
> Then your DCO chain is not correct. Please carefully read submitting
> patches, especially documents about authorship, DCO, reviewed tags.
Also there should be From: Nikhil header before the patch.
--
With best wishes
Dmitry