Re: [PATCH] x86/vmware: fix panic in vmware_hypercall_slow()

From: Borislav Petkov
Date: Tue Jun 25 2024 - 04:48:08 EST


On Tue, Jun 25, 2024 at 01:33:48AM -0700, Alexey Makhalov wrote:
> Caller of vmware_hypercall_slow() can pass NULL into *out1,
> *out2,... *out5. It will lead to a NULL pointer dereference.
>
> Check a pointer for NULL before assigning a value.

I queue your patches and *now* you find this?!

How did you test them in the first place and why was this scenario missed?

Geez.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette