Re: [PATCH v7 2/3] dt-bindings: iio: proximity: Add TYHX HX9023S

[Yasin Lee]

On 2024/6/25 13:48, Krzysztof Kozlowski wrote:
> On 25/06/2024 04:15, Yasin Lee wrote:
> > A capacitive proximity sensor
> >
> > Acked-by: Conor Dooley <conor@xxxxxxxxxx>
> > Acked-by: Jonathan Cameron <jic23@xxxxxxxxxx>
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> What? How did this happen? Where - provide lore links to prove it?
>
> NAK

My mistake.  I will remove all of them.


> > Reported-by： "Rob Herring (Arm)" <robh@xxxxxxxxxx>
> No, drop.


Got it.


> > Signed-off-by: Yasin Lee <yasin.lee.x@xxxxxxxxx>
>
> > +
> > +patternProperties:
> > +  "^channel@[0-4]$":
> > +    $ref: /schemas/iio/adc/adc.yaml
> > +    type: object
> > +
> > +    properties:
> > +      reg:
> > +        minimum: 0
> > +        maximum: 4
> > +        description: The channel number.
> > +
> > +      single-channel: true
> > +
> > +      diff-channels: true
> > +
> > +    oneOf:
> > +      - required:
> > +          - single-channel
> > +      - required:
> > +          - diff-channels
> > +
> > +    required:
> > +      - reg
> ... and now you should see that you duplicated adc.yaml. This should be
> just:
>
> +patternProperties:
> +  "^channel@[0-4]$":
> +    $ref: /schemas/iio/adc/adc.yaml
> +    type: object
> +    unevaluatedProperties: false
> +
> +    properties:
> +      reg:
> +        minimum: 0
> +        maximum: 4
> +        description: The channel number.
>
>
>
> Best regards,
> Krzysztof


Hi Krzysztof,

Thanks for your reply.

I have done the verification. "single-channel: true"and "diff-channels: 
true" are necessary. Removing them will cause dt_binding_check to report 
an error. Only oneOf can be removed. The de-duplicated code is as follows:

patternProperties:
  "^channel@[0-4]$":
    $ref: /schemas/iio/adc/adc.yaml
    type: object
    unevaluatedProperties: false

    properties:
      reg:
        minimum: 0
        maximum: 4
        description: The channel number.

      single-channel: true

      diff-channels: true

    required:
      - reg

    additionalProperties: false


Best regards,

Yasin