Re: [PATCH v8 1/2] pwm: meson: Add support for Amlogic S4 PWM

[Kelvin Zhang]

On 2024/6/17 22:11, Uwe Kleine-König wrote:
> Hello,
>
> On Mon, Jun 17, 2024 at 04:44:13PM +0800, Junyi Zhao wrote:
> > > > So yes, please use dev_err_probe() also to handle
> > > > devm_add_action_or_reset().
> > > My point here is also that devm_add_action_or_reset() can only fail on
> > > memory allocation, like (devm_)kzalloc. Looking around the kernel, we
> > > tend to not add messages for that and just return the error code,
> > > presumably because those same 'out of memory' messages would proliferate
> > > everywhere.
> > Hi Uwe, I didnt get the clear point.
> > So, if we need "return ret" directly? or keep "dev_err_probe()" to print?
> Please keep the dev_err_probe(). There is a problem with that approach
> (as Jerome pointed out), but that is about to be addressed in driver
> core code.
Hi Uwe,
For this patchset, is there anything that needs improvement?
Thanks!

> Best regards
> Uwe