Re: [PATCH 1/2] x86/fred: Always install system interrupt handler into IDT

From: Thomas Gleixner
Date: Tue Jun 25 2024 - 08:31:22 EST


On Tue, Jun 25 2024 at 02:19, Xin Li wrote:
> On 6/21/2024 6:12 AM, Hou Wenlong wrote:
>> diff --git a/arch/x86/include/asm/idtentry.h b/arch/x86/include/asm/idtentry.h
>> index d4f24499b256..daee9f7765bc 100644
>> --- a/arch/x86/include/asm/idtentry.h
>> +++ b/arch/x86/include/asm/idtentry.h
>> @@ -470,8 +470,7 @@ static inline void fred_install_sysvec(unsigned int vector, const idtentry_t fun
>> #define sysvec_install(vector, function) { \
>> if (cpu_feature_enabled(X86_FEATURE_FRED)) \
>> fred_install_sysvec(vector, function); \
>> - else \
>> - idt_install_sysvec(vector, asm_##function); \
>
> empty line, it improves readability.
>
> And please put a comment here to explain why this is unconditionally
> done for IDT.

Wait. If we need this during early boot, then why don't we enable FRED
earlier?

Thanks,

tglx