Re: [PATCH 02/17] signal: Compute the process exit_code in get_signal

From: Oleg Nesterov
Date: Tue Jun 25 2024 - 08:36:54 EST


On 06/18, Eric W. Biederman wrote:
>
> In prepartion for moving the work of sys_exit and sys_group_exit into
> get_signal compute exit_code in get_signal,

So far I don't understand the purpose of this preparation, but

> make PF_SIGNALED depend on the exit_code

> - current->flags |= PF_SIGNALED;
> + if (exit_code & 0x7f)
> + current->flags |= PF_SIGNALED;

This is another user-visible change...

PF_SIGNALED means that the task didn't exit on its own but have gone
through get_signal().

This should not affect coredump_task_exit(), but what about
acct_collect/bacct_add_tsk ?

Confused...

Oleg.