Re: [PATCH] fbdev: mmp: Constify struct mmp_overlay_ops

From: Helge Deller
Date: Tue Jun 25 2024 - 08:41:17 EST


On 6/24/24 21:59, Christophe JAILLET wrote:
'struct mmp_overlay_ops' is not modified in this driver.

Constifying this structure moves some data to a read-only section, so
increase overall security.

On a x86_64, with allmodconfig, as an example:
Before:
======
text data bss dec hex filename
11798 555 16 12369 3051 drivers/video/fbdev/mmp/hw/mmp_ctrl.o

After:
=====
text data bss dec hex filename
11834 507 16 12357 3045 drivers/video/fbdev/mmp/hw/mmp_ctrl.o

Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
---
Compile tested-only
---
drivers/video/fbdev/mmp/hw/mmp_ctrl.c | 2 +-
include/video/mmp_disp.h | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)

applied.
Thanks!
Helge