Re: [PATCH] drm/nouveau/dispnv04: fix null pointer dereference in nv17_tv_get_ld_modes

[Markus Elfring]

> In nv17_tv_get_ld_modes(), the return value of drm_mode_duplicate() is
> assigned to mode, which will lead to a possible NULL pointer dereference
> on failure of drm_mode_duplicate(). Add a check to avoid npd.

Can a wording approach (like the following) be a better change description?

  A null pointer is stored in the local variable “mode” after a call
  of the function “drm_mode_duplicate” failed. This pointer was used
  in a subsequent statement where an undesirable dereference will
  be performed then.
  Thus add a corresponding return value check.


> Cc: stable@xxxxxxxxxxxxxxx

Would you like to add the tag “Fixes” accordingly?


How do you think about to use a summary phrase like
“Prevent null pointer dereference in nv17_tv_get_ld_modes()”?


Regards,
Markus