Re: [PATCH v3 5/9] selftests/arm64: Fix build warnings for ptrace

[Mark Brown]

On Tue, Jun 25, 2024 at 05:54:04PM +0530, Dev Jain wrote:

> "%s" should have been used in ksft_exit_fail_msg(). Anyways, replace that
> with the recently introduced ksft_exit_fail_perror(). Also fix no mention of
> type_name in ksft_test_result_skip().

Reviewed-by: Mark Brown <broonie@xxxxxxxxxx>

but a couple of minor notes if this needs resending (it might be best to
send indpendently as well to help it get picked up more quickly.)

> NOTE: This patch can be applied independently of the series, but the
> next patch depends on this one.

Admin notes like this should go after the ---.

>  	if (ptrace(PTRACE_TRACEME, -1, NULL, NULL))
> -		ksft_exit_fail_msg("PTRACE_TRACEME", strerror(errno));
> +		ksft_exit_fail_perror("PTRACE_TRACEME");
>  
>  	if (raise(SIGSTOP))
> -		ksft_exit_fail_msg("raise(SIGSTOP)", strerror(errno));
> +		ksft_exit_fail_perror("raise(SIGSTOP)");

This should ideally be a separate patch, there's no overlap.

Attachment: signature.asc
Description: PGP signature