Re: [PATCH] Coresight: Set correct cs_mode for TPDM to fix disable issue

[JieGan]

On Tue, Jun 25, 2024 at 01:24:11PM +0100, Suzuki K Poulose wrote:
> On 25/06/2024 03:12, Jie Gan wrote:
> > The coresight_disable_source_sysfs function should verify the
> > mode of the coresight device before disabling the source.
> > However, the mode for the TPDM device is always set to
> > CS_MODE_DISABLED, resulting in the check consistently failing.
> > As a result, TPDM cannot be properly disabled.
> > 
> > To fix the issue:
> > Configure CS_MODE_SYSFS/CS_MODE_PERF during the enablement of TPDM.
> > Configure CS_MODE_DISABLED during the disablement of TPDM.
> > 
> > Fixes: 1f5149c7751c("coresight: Move all sysfs code to sysfs file")
> 
> That looks like the wrong commit. This was a problem since the original
> TPDM driver. I would say :
> 
> Fixes: b3c71626a933 ("Coresight: Add coresight TPDM source driver")
I will correct the Fixes tag and re-send the patch.

> 
> > Signed-off-by: Jie Gan <quic_jiegan@xxxxxxxxxxx>
> 
> Otherwise, the patch looks good to me.
> 
> Please could you also fixup "dummy" source driver in a separate patch.
Sure.

> 
> Suzuki
> 

Thanks,
Jie