Re: [PATCH v4] ACPI: Add acpi=nospcr to disable ACPI SPCR as default console on ARM64

[Liu Wei]

From: Prarit Bhargava <prarit@xxxxxxxxxx>

> On 6/24/24 23:05, Liu Wei wrote:
> > For varying privacy and security reasons, sometimes we would like to
> > completely silence the _serial_ console, and only enable it when needed.
> > 
> > But there are many existing systems that depend on this _serial_ console,
> > so add acpi=nospcr to disable console in ACPI SPCR table as default
> > _serial_ console.
> > 
> > Signed-off-by: Liu Wei <liuwei09@xxxxxxxx>
> > Suggested-by: Prarit Bhargava <prarit@xxxxxxxxxx>
> > Suggested-by: Will Deacon <will@xxxxxxxxxx>
> > Suggested-by: Andrew Lunn <andrew@xxxxxxx>
> > ---
> > 
> > v2: Add a config option suggested by Prarit
> > 
> > v3: Use cmdline acpi=nospcr instead of config
> > 
> > v4: Some description in comment or document
> > ---
> >   .../admin-guide/kernel-parameters.txt          | 10 +++++++---
> >   arch/arm64/kernel/acpi.c                       | 18 +++++++++++++++++-
> >   2 files changed, 24 insertions(+), 4 deletions(-)
> > 
> >  ... 
> > 
> 
> This looks good to me.  Sorry that this took so long Liu.
> 
> Reviewed-by: Prarit Bhargava <prarit@xxxxxxxxxx>
> 

Thanks, my pleasure.

Liu Wei
 
> 
> P.