Re: [PATCH 2/2] cpufreq: acpi: Mark boost policy as enabled when setting boost

From: Gautham R . Shenoy
Date: Wed Jun 26 2024 - 01:25:53 EST


Mario Limonciello <mario.limonciello@xxxxxxx> writes:

> When boost is set for CPUs using acpi-cpufreq the policy is not
> updated which can cause boost to be incorrectly not reported.
>
> Suggested-by: Gautham R. Shenoy <gautham.shenoy@xxxxxxx>
> Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>

Reviewed-by: Gautham R. Shenoy <gautham.shenoy@xxxxxxx>

> ---
> Cc: Sibi Sankar <quic_sibis@xxxxxxxxxxx>
> Cc: Dietmar Eggemann <dietmar.eggemann@xxxxxxx>
> Cc: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> Cc: Dhruva Gole <d-gole@xxxxxx>
> Cc: Yipeng Zou <zouyipeng@xxxxxxxxxx>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> v14->v15:
> * Use Gautham's suggestion instead
> ---
> drivers/cpufreq/acpi-cpufreq.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c
> index 37f1cdf46d29..bd3f95a7a4fe 100644
> --- a/drivers/cpufreq/acpi-cpufreq.c
> +++ b/drivers/cpufreq/acpi-cpufreq.c
> @@ -139,6 +139,7 @@ static int set_boost(struct cpufreq_policy *policy, int val)
> (void *)(long)val, 1);
> pr_debug("CPU %*pbl: Core Boosting %s.\n",
> cpumask_pr_args(policy->cpus), str_enabled_disabled(val));
> + policy->boost_enabled = val;
>
> return 0;
> }
> --
> 2.43.0