Re: [PATCH v5 2/3] hwrng: add hwrng driver for Rockchip RK3568 SoC

[Krzysztof Kozlowski]

On 26/06/2024 03:37, Daniel Golle wrote:
> From: Aurelien Jarno <aurelien@xxxxxxxxxxx>
> 
> Rockchip SoCs used to have a random number generator as part of their
> crypto device, and support for it has to be added to the corresponding
> driver. However newer Rockchip SoCs like the RK3568 have an independent
> True Random Number Generator device. This patch adds a driver for it,
> greatly inspired from the downstream driver.
> 
> The TRNG device does not seem to have a signal conditionner and the FIPS
> 140-2 test returns a lot of failures. They can be reduced by increasing
> RK_RNG_SAMPLE_CNT, in a tradeoff between quality and speed. This value
> has been adjusted to get ~90% of successes and the quality value has
> been set accordingly.
> 
> Signed-off-by: Aurelien Jarno <aurelien@xxxxxxxxxxx>
> [daniel@xxxxxxxxxxxxx: code style fixes]
> Signed-off-by: Daniel Golle <daniel@xxxxxxxxxxxxxx>


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Krzysztof