Re: [PATCH 1/3] power: supply: ab8500: Fix error handling when calling iio_read_channel_processed()

From: Linus Walleij
Date: Wed Jun 26 2024 - 06:39:06 EST


On Sat, Jun 22, 2024 at 9:05 AM Christophe JAILLET
<christophe.jaillet@xxxxxxxxxx> wrote:

> The ab8500_charger_get_[ac|vbus]_[current|voltage]() functions should
> return an error code on error.
>
> Up to now, an un-initialized value is returned.
> This makes the error handling of the callers un-reliable.
>
> Return the error code instead, to fix the issue.
>
> Fixes: 97ab78bac5d0 ("power: supply: ab8500_charger: Convert to IIO ADC")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>

Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij