Re: [PATCH 7/7] arm64: dts: broadcom: bcm2712: Add PCIe DT nodes

[Florian Fainelli]

On 26/06/2024 11:45, Stanimir Varbanov wrote:
> Add PCIe device tree nodes.
>
> Signed-off-by: Stanimir Varbanov <svarbanov@xxxxxxx>
> ---
>   arch/arm64/boot/dts/broadcom/bcm2712.dtsi | 218 ++++++++++++++++++++--
>   1 file changed, 202 insertions(+), 16 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/broadcom/bcm2712.dtsi b/arch/arm64/boot/dts/broadcom/bcm2712.dtsi
> index bccb7318ce7e..358b129a0f65 100644
> --- a/arch/arm64/boot/dts/broadcom/bcm2712.dtsi
> +++ b/arch/arm64/boot/dts/broadcom/bcm2712.dtsi
> @@ -186,17 +186,30 @@ cma: linux,cma {
>   		};
>   	};
>   
> -	soc: soc@107c000000 {
> +	soc: soc@0 {

That is churning this node too much, please move the PCIe node outside 
of this soc Device Tree node and just have it at the top-level.
--
Florian

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature